Home page - tags display wrongly
Oorspronkelijk bericht onderwerp: Hoe page - tags display wrongly
DiscussieBug Collectors
Sluit je aan bij LibraryThing om te posten.
1DuncanHill
On my /home my tags are displaying vertically, even though horizontal is chosen. Go into settings, see it still says horizontal, click save, and they then display horizontally. Navigate away and back to /home, and they are vertical again.
2norabelle414
Seems to be happening to a lot of different home page modules. I see it for "your tags" as well as "your collections", "lists you've started" "lists you've favorited", and "your zeitgeist"
3shadrach_anki
I have also seen this. It also seems to be affecting "Recent Member-uploaded Covers for Your Books", albeit in a different fashion (only four covers are showing, with lots of white space between each image).
The same behavior is occurring in Firefox, Chrome, and Edge.
The same behavior is occurring in Firefox, Chrome, and Edge.
5CDVicarage
My Collections list is only one column, instead of three and my Tags list is also affected. If I edit and save (the same) settings it goes back to columns but as when I come to my Home Page after visiting another page it's back to a single column again.
6SandraArdnas
Ever since the fatal error yesterday. Resaving your setting fixes it, but only temporarily. As soon as the homepage refreshes, it's back to vertical
7conceptDawg
Thanks. I'll take a look.
8kristilabrie
>7 conceptDawg: Also happening on "Lists You've Favorited", reported here: https://www.librarything.com/topic/338702
9gilroy
>8 kristilabrie: That was mentioned in >2 norabelle414:
10kristilabrie
>9 gilroy: Thanks.
11Nicole_VanK
Confirming. Same goes for collections
12FiLoMa
I'm experience the same problem that DuncanHill reported, both for my tags and my collections. I first noticed it the other day but thought it was something I had done, but as DuncanHill mentions, my settings are correct and changing them and changing them back holds only for that duration. The moment I refresh my page or leave and come back to my Home it displays my tags and collections down the page in one column rather than across in several columns.
13kristilabrie
Bringing the LibraryThing Roulette module bug over here, too, since it's likely related: https://www.librarything.com/topic/338691
14bookbeat
I've got the same thing going on yesterday & today even though I went in & changed then saved it.
15bookishbill
It seems to be fixed now.
16conceptDawg
Mostly fixed. I'm trying to correct a couple of minor inconsistencies with certain settings enabled. But it should be fixed for most people now.
17norabelle414
It looks fixed for "your tags" and "your collections" but not for "your zeitgeist" and everything on the "lists" subpage
18conceptDawg
Those should be fixed now also.
I also cleaned up the Lists view so that we should have fewer overlapping titles and images.
I also cleaned up the Lists view so that we should have fewer overlapping titles and images.
19CDVicarage
The original problem - one column only - has been solved but now the display reverts to 9 columns (for collections) and 10 (for Tags), which means that they all overwrite each other. Again, editing the settings makes them go back to the correct 3 and 4 columns, only to go back to the overlapping view when you return to the Home page.
20Foretopman
>19 CDVicarage: Yes, I'm seeing the same thing.
21Nicole_VanK
>19 CDVicarage: Confirming
22VivienneR
>19 CDVicarage: Same here.
23conceptDawg
Thanks. I'll take a look as soon as I can.
24gilroy
>19 CDVicarage: Um, can you say what browser and operating system this is on?
Cause I'm not seeing this problem on Firefox on Windows 10
Cause I'm not seeing this problem on Firefox on Windows 10
25rodneyvc
>24 gilroy: Seeing this on MacOS 10.15.7, FF 96.0, also Safari 15.2
26CDVicarage
>24 gilroy: I have Windows 11 and Firefox, although it's the same using Chrome
27conceptDawg
>19 CDVicarage:
So let's get more in the weeds here.
On the home page the number of columns shown in Collections and Tags modules are dependent on the size of your display: if you have a wider display it knows that it can show more columns, so it breaks the data up into more columns.
"Again, editing the settings makes them go back to the correct 3 and 4 columns, only to go back to the overlapping view when you return to the Home page."
What settings are you changing?
Where are you viewing this data, other than the home page?
So let's get more in the weeds here.
On the home page the number of columns shown in Collections and Tags modules are dependent on the size of your display: if you have a wider display it knows that it can show more columns, so it breaks the data up into more columns.
"Again, editing the settings makes them go back to the correct 3 and 4 columns, only to go back to the overlapping view when you return to the Home page."
What settings are you changing?
Where are you viewing this data, other than the home page?
28rodneyvc
>27 conceptDawg: I'm on an iMac 21" and on the home page I've started seeing the following:
If I go to edit the setting
to 25 tags, and save, and then set it back to 30 tags, and save I see the following
which is what I was seeing before this issue occurred.
Re-loading the home page takes me back to the first image.
If I go to edit the setting
to 25 tags, and save, and then set it back to 30 tags, and save I see the following
which is what I was seeing before this issue occurred.
Re-loading the home page takes me back to the first image.
29conceptDawg
Thanks for the extra information. You're seeing a different result than me, so it's very helpful.
30DuncanHill
>29 conceptDawg: Mine are displaying with the first column much longer than the others. If I knew how to post a screenshot here I would. If I open the setting and save without changing anything they reset to equal lengths, but revert to first one longer if I navigate away and back or refresh the page. Edge on Win10.
Edit: I think I might have discovered how to add a screenshot.
Edit: I think I might have discovered how to add a screenshot.
31VivienneR
Screenshots of collections and tags from my homepage. I can edit using the pencil in the top right of the title bar but they revert to this when the page is reloaded.
32conceptDawg
Thanks for these. They give me good datapoints to look at. This is ancient code that is calling new code that has changed in preparation for a transition to new design/features but is in a kind of half-ready state. So fixing it is quite a challenge.
33njcur
Thanks for all your hard work. It is worth the wait for all the great features y'all offer! Thank you, thank you, thank you!
34conceptDawg
I've pushed a new fix for the home page tag and collections modules.
You may have to resave your settings for each module to get them how you want them but home page module settings should save correctly now.
As always, if you have problems let me know.
You may have to resave your settings for each module to get them how you want them but home page module settings should save correctly now.
As always, if you have problems let me know.
35VivienneR
>34 conceptDawg: Beautiful! Thank you so much! It was such a treat to open my homepage and see everything as it should be instead of a mashed version. I appreciate your hard work enormously.
36conceptDawg
There are some minor differences in the display vs. the old version but those will be ironed out as we release an updated Home page that can handle all of the LT2 styling (soon, I hope).
37rodneyvc
>36 conceptDawg: That's a big improvement. May I just illustrate some creases to iron out:
In the Horizontal setting the numbers can be orphaned from the tag - see Autobiography below
In the Vertical setting the slightly narrow choice of column width is causing an odd appearance, but the numbers aren't orphaned.
In both cases clicking on the tag takes me to the items in my library, and the numbers aren't clickable. This doesn't worry me, but others may be expecting to go to either the tag page, or their collection.
In the Horizontal setting the numbers can be orphaned from the tag - see Autobiography below
In the Vertical setting the slightly narrow choice of column width is causing an odd appearance, but the numbers aren't orphaned.
In both cases clicking on the tag takes me to the items in my library, and the numbers aren't clickable. This doesn't worry me, but others may be expecting to go to either the tag page, or their collection.
38conceptDawg
Yeah, the orphaning is something that I worked on correcting but then you have to deal with long tag names and we don't want those doing crazy things. And I can't control the column wrapping of the number unless I wrap it with the tag. I'll be working on ironing out some idiosyncracies when we update Home display code to LT2.
The The action of the links hasn't changed.
The The action of the links hasn't changed.
39Nicole_VanK
>38 conceptDawg: I'm now experiencing another oddity in "collections" on my home page. It says "Your library" (4) - while that is in fact 4695 - and "Art History" (1) -in fact 1532.
Still a huge improvement though. Thank you.
Still a huge improvement though. Thank you.
40CDVicarage
>39 Nicole_VanK: Same for me - several of my largest collections (numerically) have only the first digit on display. I think it's those collection with contents of over 1000 .
41CDVicarage
The columns for Your Zeitgeist on my home page are still squashed and overwriting each other. Your Collections and Your Tags (the only other columned displays) are fine now (apart from the above in >40 CDVicarage:)
42link_rae
>40 CDVicarage: same here !
43aspirit
The horizontal view is working for me now, but the font size of the tags module is so large that on my phone, only six characters fit on a line, so many of the tags are each broken onto multiple lines within the column. Example:
anthol
ogy
(143)
anthol
ogy
(143)
44kristilabrie
Also reported at https://www.librarything.com/topic/339136
45conceptDawg
>41 CDVicarage: I'll check that one next then. Zeitgeist.
>43 aspirit: What LT style are you using (font/font-size)? Or, do you have the view zoomed in? Is the font size for the Tags module larger than the other fonts on the page? If not, then what browser?
Book/Collections counts
I'll check on the counts. I didn't change that particular bit of code but I guess there's a disconnect somewhere. I'll track it down.
>43 aspirit: What LT style are you using (font/font-size)? Or, do you have the view zoomed in? Is the font size for the Tags module larger than the other fonts on the page? If not, then what browser?
Book/Collections counts
I'll check on the counts. I didn't change that particular bit of code but I guess there's a disconnect somewhere. I'll track it down.
46conceptDawg
Counts have been corrected.
Zeitgeist now uses a new modern layout (which will pay dividends in the near future).
I made another stab at the Name (count) orphaning and splitting of long words, etc.
Zeitgeist now uses a new modern layout (which will pay dividends in the near future).
I made another stab at the Name (count) orphaning and splitting of long words, etc.
47AnnieMod
>46 conceptDawg: It looks much better now (both my long collection names splitting and the numbers). Thanks!
48aspirit
>45 conceptDawg: I have Talk set to Verdana Small (the B choice). My LT Home page opens on the default mobile view, so 100% zoom. The font size for the Tags module appears at least twice as large as most of the other text on the page, except for it's roughly the same as when the headers are larger than usual (a seemingly random reoccurrence).
This is an Android device.
This is an Android device.
49igorken
I'm seeing more column weirdness today, in a different way than I had before:
"Your collections" is splitting in a strage way in that longer collection names (eg "Read but unowned") are being split across two lines. Then there is loads of whitespace at the end.
"Hot reviews" is showing 3 columns of reviews, where it used to show 2. Clicking its settings, without changing anything, it then displays 2 again.
This is on my laptop, using the latest Firefox.
"Your collections" is splitting in a strage way in that longer collection names (eg "Read but unowned") are being split across two lines. Then there is loads of whitespace at the end.
"Hot reviews" is showing 3 columns of reviews, where it used to show 2. Clicking its settings, without changing anything, it then displays 2 again.
This is on my laptop, using the latest Firefox.
51conceptDawg
>49 igorken:
Yes. The new display code may split long lines so that it can show fewer/more columns. The browser ultimately decides where/when. And it is also affected by your window/device screen size, font style selection, and zoom level. It's complicated. The code before basically broke if ANY of those things changed.
Ah. the Hot Reviews thing must have the same settings bug that the tag and collections modules had last week. I'll take a look and make sure it's saving it's settings correctly.
>50 Taliesien: "constant" = first reworking off that code in 10 years. But, yes, there might be some minor changes to it as we iron out the new display styles.
Yes. The new display code may split long lines so that it can show fewer/more columns. The browser ultimately decides where/when. And it is also affected by your window/device screen size, font style selection, and zoom level. It's complicated. The code before basically broke if ANY of those things changed.
Ah. the Hot Reviews thing must have the same settings bug that the tag and collections modules had last week. I'll take a look and make sure it's saving it's settings correctly.
>50 Taliesien: "constant" = first reworking off that code in 10 years. But, yes, there might be some minor changes to it as we iron out the new display styles.